Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Github Action to update the TLSA record in our integration tests automatically #499

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Add a Github Action to update the TLSA record in our integration tests automatically #499

merged 6 commits into from
Jan 10, 2025
+539 −251

Conversation

phillip-stephens
Copy link
Contributor

  • Run python formatter black on our integration_tests.py (Reason for most changes)
  • Add GitHub action to update TLSA record when dig shows it's changed
  • Add black to our usual lint routine (both in makefile and in the lint action that runs on all PR's

@phillip-stephens phillip-stephens marked this pull request as ready for review January 9, 2025 23:27
@phillip-stephens phillip-stephens requested a review from a team as a code owner January 9, 2025 23:27
@phillip-stephens
Copy link
Contributor Author

@zakird So every month or two the TLSA record we test against gets updated. This action should make a PR when that happens. However, I can't fully test the Github Action workflow until it's merged into main. Right now this just fails because the TLSA record is not correct. If it looks good to you, can we merge and then we can be sure the action creates a PR as intended?

@zakird zakird merged commit 29a8c3f into main Jan 10, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakird zakird zakird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillip-stephens @zakird